Skip to content

Conversation

@ctb
Copy link
Member

@ctb ctb commented Oct 25, 2015

Fixes #1320.

@ctb
Copy link
Member Author

ctb commented Oct 25, 2015

  • Is it mergeable?
  • Did it pass the tests?
  • If it introduces new functionality in scripts/ is it tested?
    Check for code coverage with make clean diff-cover
  • Is it well formatted? Look at make pep8, make diff_pylint_report,
    make cppcheck, and make doc output. Use make format and manual
    fixing as needed.
  • Did it change the command-line interface? Only additions are allowed
    without a major version increment. Changing file formats also requires a
    major version number increment.
  • Is it documented in the ChangeLog?
    http://en.wikipedia.org/wiki/Changelog#Format
  • Was a spellchecker run on the source code and documentation after
    changes were made?
  • Do the changes respect streaming IO? (Are they
    tested for streaming IO?)
  • Is the Copyright year up to date?

Ready for review & merge, @luizirber @camillescott. This is an easy one I think :)

@luizirber luizirber force-pushed the fix/early_file_close branch from 7bd4bc1 to ce8f83e Compare October 28, 2015 19:25
@luizirber
Copy link
Member

LGTM

luizirber added a commit that referenced this pull request Oct 28, 2015
fix and test for close of --output file after first input file
@luizirber luizirber merged commit 0cbd318 into master Oct 28, 2015
@luizirber luizirber deleted the fix/early_file_close branch October 28, 2015 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants